Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 8 #373

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Upgrade to Rails 8 #373

merged 1 commit into from
Jan 7, 2025

Conversation

csutter
Copy link
Contributor

@csutter csutter commented Jan 7, 2025

  • Bump Rails to 8.0.1
  • Run rails app:update and integrate changes/new defaults
  • Set framework defaults to 8.0 directly (no major changes that affect this app and would need applying incrementally)

- Bump Rails to 8.0.1
- Run `rails app:update` and integrate changes/new defaults
- Set framework defaults to `8.0` directly (no major changes that affect
  this app and would need applying incrementally)
Copy link
Contributor

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small inline question.

end

# Change to :null_store to avoid any caching.
config.cache_store = :memory_store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this added by running app:update? Seems like a mixed message to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's the new default description for the option 😬 I think it means change it to :null_store if you don't want caching but it's a bit meh.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I completely misread that, most likely due to it being originally being set to :null_store
So we weren't caching before, but now we will be? Is that the expected behaviour for the dev environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah – the diff is a bit ugly because of the if statement but yes, caching in development is the new default in Rails 8 (Action Controller caching is still toggled by the trigger file tmp/caching-dev.txt).

We don't use the Rails cache directly for anything in this app anyway, so it's not an issue here, but may cause some head scratching on other apps down the line?

@csutter csutter merged commit 44e733a into main Jan 7, 2025
8 checks passed
@csutter csutter deleted the rails8 branch January 7, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants